bdkjones / CodeKit2

CodeKit 2 Beta
97 stars 4 forks source link

Codekit should modify config.rb #568

Open ehausen opened 9 years ago

ehausen commented 9 years ago

Right now Codekit overrides some of Compass configuration set in config.rb if they are set in Codekit.

http://incident57.com/codekit/help.html#compass

Starting in CodeKit 2.1.9, compiling options (output style, debug information, source maps, etc.) for Sass files in a Compass project are controlled Soley in CodeKit's UI. The process works just like it does for Sass files in a non-Compass project. The settings for these options in the Compass config.rb file will be overridden by the settings in CodeKit's UI.

I think this can be problematic and confusing and might cause problems especially if there is more than one people involved.

I think Codekit should write the settings to config.rb file so that it has right Compass settings, as it should. This way they are found were they should be if other people are looking for them.

I just inherited a Compass project I quickly want to fix, and I wouldn't want anything to be different.

ehausen commented 9 years ago

Bryan also writes: http://incident57.com/codekit/help.html#compass

Why Did You Change This? CodeKit 2.1.9 made Autoprefixer and Bless available for Sass files in Compass projects. These two options are controlled in CodeKit's UI; there is no command you can add to the config.rb file to enable them. It seemed dumb to have those two compiling options in the UI but require you to edit the config file to change other options. Therefore, I migrated all compiling options to the UI.

My eventual goal is to eliminate the need for config.rb files completely. You would only use that file to set up advanced Compass actions, like running extra Ruby code after compiling, etc. To do this, I'll need some changes on Compass's end, however.

I think maybe these things could also be written to config.rb, maybe as a custom comment or something that Codekit would know how to read.

My point is that when I'm opening a Compass project it's should work on other than Codekit. Otherwise it's not Compass anymore.

bdkjones commented 9 years ago

The reason CodeKit does not do this is because the config.rb file does not allow the same granularity of settings. If you rely on the config.rb file, ALL your Sass files are one output type or another. CodeKit allows you to specify the output type on a file-by-file basis. There is no way to express that in the config.rb file.

On 18 Jun 2015, at 02:15, vulfox notifications@github.com wrote:

Bryan also writes: http://incident57.com/codekit/help.html#compass http://incident57.com/codekit/help.html#compass Why Did You Change This? CodeKit 2.1.9 made Autoprefixer and Bless available for Sass files in Compass projects. These two options are controlled in CodeKit's UI; there is no command you can add to the config.rb file to enable them. It seemed dumb to have those two compiling options in the UI but require you to edit the config file to change other options. Therefore, I migrated all compiling options to the UI.

My eventual goal is to eliminate the need for config.rb files completely. You would only use that file to set up advanced Compass actions, like running extra Ruby code after compiling, etc. To do this, I'll need some changes on Compass's end, however.

I think maybe these things could also be written to config.rb, maybe as a custom comment or something that Codekit would know how to read.

My point is that when I'm opening a Compass project it's should work on other than Codekit. Otherwise it's not Compass anymore.

— Reply to this email directly or view it on GitHub https://github.com/bdkjones/CodeKit/issues/568#issuecomment-113084912.

ehausen commented 9 years ago

Maybe expressing it in comments in a way that Codekit can read?

bdkjones commented 9 years ago

Why would that be beneficial? Nothing else would read those comments, so it would still be a CodeKit-only thing.

Sent from my iPhone

On Jun 25, 2015, at 11:44, vulfox notifications@github.com wrote:

Maybe expressing it in comments in a way that Codekit can read?

— Reply to this email directly or view it on GitHub.

ehausen commented 9 years ago

I'm thinking that a project might be tossed around also with people who don't have codekit. Then it would be beneficial to have configuration information in the same place at least.

Can it be called Compass any more if you use extra features? Should Compass be just Compass and then have Codekit-Sass (based on Compass) separately ?

Do you understand my reasoning at all? :D

bdkjones commented 9 years ago

For years I left Compass as-is. And I would get email after email from folks that complained about not being able to modify file settings on Sass files in Compass projects. So I implemented that. Now I'm getting complaints the other way. You can't win as a developer, man.

ehausen commented 9 years ago

No you can't :D

Compass should implement the things you are doing! :D

But I guess is still possible to work with shared Compass projects with Codekit without messing up the system, if you don't add any extra settings in Codekit