search

bdlukaa / fluent_ui

Implements Microsoft's WinUI3 in Flutter.
https://bdlukaa.github.io/fluent_ui/
BSD 3-Clause "New" or "Revised" License
2.98k stars 465 forks source link

🐛 `showDialog` `barrierDismissible` documentation has contradictory "default value" #1084

Closed jacksonb-cs closed 4 months ago

jacksonb-cs commented 4 months ago

Describe the bug showDialog's documentation says the default value of barrierDismissible is true:

/// The `barrierDismissible` argument is used to indicate whether tapping on the
/// barrier will dismiss the dialog. It is `true` by default and can not be `null`.

However, the default value is false.

To Reproduce Steps to reproduce the behavior:

  1. View showDialog source

Expected behavior The documentation should be changed (as opposed to the default value) to say that the default value is false.

Additional context I can open a pull request when I'm done with work if no one beats me to it.