search

bdougherty / BigScreen

A simple library for using the JavaScript Full Screen API.
https://brad.is/coding/BigScreen/
MIT License
710 stars 77 forks source link

BigScreen.element needs to check for all <video>s #5

Closed bdougherty closed 11 years ago

bdougherty commented 11 years ago

It only checks for the one it knows about called explicitly through request(), but it's possible for a <video> to enter fullscreen automatically when it starts (for example, on the iPhone).

I think the best way is to select all videos when element is called and check each one. That means document[fn.element] should be checked first to avoid unnecessary DOM interaction.

bdougherty commented 11 years ago

Fixed by bf83a10057fe36426f3e454f5b3c3ec197e7a5b6 (made possible by 4c24fafd0d04d5d1ef4f156d711939ecc9a316f4)