search

bdougherty / BigScreen

A simple library for using the JavaScript Full Screen API.
https://brad.is/coding/BigScreen/
MIT License
710 stars 77 forks source link

v2.0.4 throwing "addEventListener" error in IE8 #9

Closed noahgrant closed 9 years ago

noahgrant commented 10 years ago

Hello,

I'll hack around it, but I wanted to let you know that I can't just test BigScreen.enabled in IE8 because there is an unchecked use of "addEventListener" in the code that is throwing an error. Therefore BigScreen doesn't exist, and a fatal error occurs when looking for a property on the undefined object.

Thanks!

Noah

Niklas-Peter commented 10 years ago

Will this issue be fixed or can you tell me how to fix it temporary, because I want to use BigScreen at a page, that needs to be compatible to IE8 in sense of graceful degradation. It would be enough if BigScreen.enabled simply returns false in this case, so that my fallback routine is executed.

bdougherty commented 10 years ago

Sorry for the delay! I will try to have the fix done and released this week.