Project Feedback - Githubissues

bdpettway19 commented 7 years ago

@stuartpearman Can you take a look at this? It's hosted here and meets the following criteria:

[x] Includes a button that when clicked, will toggle the website between day and night themes
[x] When a user changes the theme, their choice is remembered in localStorage
[x] The class on the body element is always up-to-date with the current theme (either day-theme or night-theme) -- you can use document.body.setAttribute('class', 'some-class-name') to set the class on the body
[x] When the body has the class day-theme, the background of the website is light-colored, with a darker color for the text
[x] When the body has the class night-theme, the background of the website is a very dark color, with a lighter color for the text
[x] Somewhere on the page, the user is told how many times they've visited the website (starting with 1 the first time)

stuartpearman commented 7 years ago

Hey Barry,

Javascript doesn't like the way we added the paragraph to the body, and now the day and night buttons don't work. The best way to fix this is probably to add a paragraph to our HTML, and put the loaded_num text into it with document.getElementById

I also definitely want to see the formatting cleaned up, if you don't have a javascript linter installed, read this slide about installing the JS Standard Linter.

Let me know if you have any questions :+1:

bdpettway19 commented 7 years ago

Ready to check!

stuartpearman commented 7 years ago

:shipit:

bdpettway19 / MI-449-SS17-741-js-localstorage-wMUDce

Project Feedback #1