search

bdraco / nexia

Python library for connecting to nexia
Apache License 2.0
21 stars 13 forks source link

Adding extra handling for 'type' missing in 'thermostat_json'. #3

Closed jeroenterheerdt closed 4 years ago

jeroenterheerdt commented 4 years ago

I have been using this package as part of my Home Assistant integration but it was broken. I was able to trace it back to not enough checks if 'type' existed in the thermostat_json. Adding those extra checks in this PR. Have not touched anything else.

jeroenterheerdt commented 4 years ago

hope you can merge this and update the python package so the Home Assistant integration can work again :)

ryannazaretian commented 4 years ago

I don't see any issues with the primary change. Please remove your configuration file from the commit.

jeroenterheerdt commented 4 years ago

oops... removed the conf file now. By the way, the reason for this change is that if a sensor has been added to the z-wave network but has not been fully configured, it will be reported separately in the thermostat_json, but there is no type.