bdraco / yalexs-ble

Bluetooth control of Yale and August locks
GNU General Public License v3.0
10 stars 1 forks source link

fix: always stop notify before shutting down the session #122

Closed bdraco closed 1 year ago

bdraco commented 1 year ago

The theory is that is a gatt notify happens while disconnecting the lock crashes so we stop the notify before we disconnect

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.07 :warning:

Comparison is base (fd81a67) 32.11% compared to head (e64df83) 32.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #122 +/- ## ========================================== - Coverage 32.11% 32.05% -0.07% ========================================== Files 7 7 Lines 1037 1039 +2 Branches 170 171 +1 ========================================== Hits 333 333 - Misses 699 701 +2 Partials 5 5 ``` | [Impacted Files](https://codecov.io/gh/bdraco/yalexs-ble/pull/122?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=J.+Nick+Koston) | Coverage Δ | | |---|---|---| | [src/yalexs\_ble/lock.py](https://codecov.io/gh/bdraco/yalexs-ble/pull/122?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=J.+Nick+Koston#diff-c3JjL3lhbGV4c19ibGUvbG9jay5weQ==) | `28.11% <0.00%> (-0.27%)` | :arrow_down: | | [src/yalexs\_ble/\_\_init\_\_.py](https://codecov.io/gh/bdraco/yalexs-ble/pull/122?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=J.+Nick+Koston#diff-c3JjL3lhbGV4c19ibGUvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=J.+Nick+Koston). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=J.+Nick+Koston)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.