bdraco / yalexs

Python API for Yale Access (formerly August) Smart Lock and Doorbell
MIT License
38 stars 18 forks source link

Add unlatch action #101

Closed m10x closed 6 months ago

m10x commented 6 months ago

added the unlatch action, so door can not only be locked/unlocked but also opened by unlatching the lock.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 98.09524% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.83%. Comparing base (2fb5f85) to head (027e7fe).

Files Patch % Lines
yalexs/api.py 83.33% 1 Missing :warning:
yalexs/api_async.py 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #101 +/- ## ========================================== + Coverage 95.76% 95.83% +0.06% ========================================== Files 29 29 Lines 3424 3528 +104 ========================================== + Hits 3279 3381 +102 - Misses 145 147 +2 ``` | [Flag](https://app.codecov.io/gh/bdraco/yalexs/pull/101/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=J.+Nick+Koston) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/bdraco/yalexs/pull/101/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=J.+Nick+Koston) | `95.83% <98.09%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=J.+Nick+Koston#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

m10x commented 6 months ago

I'll try to add more tests (probably later today)

m10x commented 6 months ago

I was confused at firsttest_manual_unlatch_activity_v4, because I misinterpreted Unlatch as Manual Unlatch in my logs. But now the tests should be fine :)

m10x commented 6 months ago

CI passed but Codecov is down by 0.03%

bdraco commented 6 months ago

I need to find some time to test this on my production before merging.

Once I do that I'll make a release

bdraco commented 6 months ago

published to pypi as 3.0.0

Thanks @m10x