bdraco / yalexs

Python API for Yale Access (formerly August) Smart Lock and Doorbell
MIT License
40 stars 19 forks source link

Add more unlock methods #86

Closed Olen closed 4 months ago

Olen commented 1 year ago

I have a Doorman v2n ("Doorman Classic"), and just migrated from Verisure to the Yale module and this integration. I have tested operatiing the lock using various methods - tags, code, manual unlock, mobile app etc. It seems like both using a tag and doing a manual unlock is reported in HA as operator method = mobile

I guess that is because of this final "else":

        else:
            attributes[ATTR_OPERATION_METHOD] = OPERATION_METHOD_MOBILE_DEVICE

https://github.com/home-assistant/core/blob/6752af8f27516be52600c1782f160d724760e869/homeassistant/components/august/sensor.py#L224-L225

And it seems like the other methods are not reported by yalexs:

https://github.com/bdraco/yalexs/blob/4ea45b2fc6af504f0a086c1e9a889eb2f30c56d3/yalexs/activity.py#L423-L436

However, they seem to be defined:

https://github.com/bdraco/yalexs/blob/4ea45b2fc6af504f0a086c1e9a889eb2f30c56d3/yalexs/activity.py#L59-L78

The thumbnails i see for both manual unlock:

manual

and tag:

rf

seems to represent the correct unlock method, so I think the lock is actually reporting the right method.

bdraco commented 1 year ago

We likely have many of the in the list but they may not be mapped (correctly?) to a lock or unlock operation.

I don't have a doorman (they are not sold in the US market) so support has been the effort of other contributors opening PR as well as what little information I've been able to glean from logs and diagnostics

bdraco commented 1 year ago

If you can add test fixtures for the pubnub messages and activity api from your testing results, I can help you get a PR merged

bdraco commented 4 months ago

closed via https://github.com/bdraco/yalexs/pull/87