search

bdraco / yalexs

Python API for Yale Access (formerly August) Smart Lock and Doorbell
MIT License
40 stars 19 forks source link

Add contentToken Auth header for camera images (Yale home) #92

Closed abjorck closed 9 months ago

abjorck commented 9 months ago

Yale Home has added some cameras, and are protecting the image urls with a separate, shorter lived, token.

Falling back to blank should not break anything for August/Yale Access, I presume.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a82b770) 95.69% compared to head (f4da709) 95.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #92 +/- ## ======================================= Coverage 95.69% 95.70% ======================================= Files 29 29 Lines 3369 3376 +7 ======================================= + Hits 3224 3231 +7 Misses 145 145 ``` | [Flag](https://app.codecov.io/gh/bdraco/yalexs/pull/92/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=J.+Nick+Koston) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/bdraco/yalexs/pull/92/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=J.+Nick+Koston) | `95.70% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=J.+Nick+Koston#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

abjorck commented 9 months ago

It seems like the format checker is failing me on files that I haven't touched - should it be like that? :)

edit: even if I do reformat everything, black and flake8 seem to be in conflict, I can't get both to pass this ./yalexs/backports/functools.py:35:5: E704 multiple statements on one line (def)

bdraco commented 9 months ago

I fixed the lint issues, but codecov seems to be broken at the moment.

I'll try it again later tonight, if its still broken, closing and reopening the PR will make the CI run again