search

bdring / FluidNC

The next generation of motion control firmware
Other
1.61k stars 383 forks source link

standarized on one delay(ms) call #1251

Closed craiglink closed 4 months ago

craiglink commented 4 months ago

The code base currently has 3 calls to delay for X number of milliseconds.

This change standarized on the default delay(ms) call which just calls vTaskDelay() under the covers. It also updates the x86 support to do the same.

The custom delay_ms(ms) in the code base has the same implementation as delay(ms), so those calls have been updated to just use delay(ms).

craiglink commented 4 months ago

I was debating that as well. I chose to go with the Arduino one because of the number of 3rd party Arduino based libraries included in the project. But I’d be fine other other way as well. Want me to do that with this PR?

craiglink commented 4 months ago

The only discord comments I saw from you are the ones I responded too in discord.

MitchBradley commented 4 months ago

https://discord.com/channels/780079161460916227/1258511678287646730/1258511678287646730

If you could implement that plan, it would be great.

craiglink commented 4 months ago

looks like you beat me to it here - https://github.com/bdring/FluidNC/pull/1255/files