search

bdring / PendantsForFluidNC

Pendants for controlling FluidNC CNC firmware
Other
34 stars 14 forks source link

Reactive json #9

Closed bDuthieDev closed 10 months ago

bDuthieDev commented 10 months ago

Revised Sort Order. Update to FilePreview

MitchBradley commented 10 months ago

I will merge it, but I want to point out that the "files before folders" sort order takes away control from users. If the order is strictly alphabetic, I can make folders appear wherever I want by choosing names.

bDuthieDev commented 10 months ago

It was folders/files/alpha based on case. Just changed it to match webUI.

Others options could include: alpha only based on case alpha only ignore case

From: Mitch Bradley @.> Sent: Wednesday, January 10, 2024 11:56 AM To: bdring/PendantsForFluidNC @.> Cc: bDuthieDev @.>; Author @.> Subject: Re: [bdring/PendantsForFluidNC] Reactive json (PR #9)

I will merge it, but I want to point out that the "files before folders" sort order takes away control from users. If the order is strictly alphabetic, I can make folders appear wherever I want by choosing names.

— Reply to this email directly, view it on GitHubhttps://github.com/bdring/PendantsForFluidNC/pull/9#issuecomment-1885235617, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AONE4W25GFNQJYHLLQ2UHSDYN3B4BAVCNFSM6AAAAABBU4ZCWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVGIZTKNRRG4. You are receiving this because you authored the thread.Message ID: @.***>

MitchBradley commented 10 months ago

There is no perfect answer. ASCII collating order is easy but it doesn't match the way most people think. Ignore case is better but gets tricky with international alphabets - but since SD filenames don't really handle unicode, we can probably ignore that subtlety.

WebUI has an advantage that makes folders-at-the-end somewhat easier to use - the window is bigger and you can drag the scrollbar down in one motion. I can imagine that getting to folders with the dial might be tedious. But maybe a hefty spin would do it, in conjunction with that nifty arc shaped scrollbar that Bart designed

Maybe the smooth scroll animation should be suppressed if the delta is large.

The visuals in the reactive json branch are not meant to be definitive. Basically I just took what was in the working branch and unwound the statefulness, without consideration of the latest visual design. If you could update the visuals that would be great