search

bdunderscore / modular-avatar

Other
449 stars 54 forks source link

Consider making AnimationServicesContext public #859

Open enitimeago opened 2 months ago

enitimeago commented 2 months ago

Use cases:

The class itself seems safe for making public, since using it is as straightforward as

seq.WithRequiredExtension(typeof(AnimationServicesContext), _ =>
{
    seq.Run(MyPass.Instance); // does renames on GameObjects, animations get automagically handled
});

I haven't used AnimationDatabase and PathMappings directly, so I don't have an opinion on these properties in AnimationServicesContext.

(This is possibly more suited for NDMF? Merge this with https://github.com/bdunderscore/ndmf/issues/111?)

bdunderscore commented 2 months ago

The main issue is I do plan on revisiting the internals of this in order to improve merge animator performance; I’m not sure if that would impact the semantics of this. So making this public might have to wait until I know what I’ll be doing there - but feel free to copy it into your project in the meantime.