Implement VRCAnimatorPlayAudio handling logic

bdunderscore / modular-avatar

Other

496 stars 66 forks source link

Implement VRCAnimatorPlayAudio handling logic #899

Closed JLChnToZ closed 3 months ago

JLChnToZ commented 3 months ago

This is my attempt to implement handling source path inside VRCAnimatorPlayAudio for Modular Avatar. (#783, #858) It is a quite dirty approach and don't know if the code quality is qualifiable to merge into upstream so I file a PR here anyways.

Before Animator Merging:

After Animator Merging:

bdunderscore commented 3 months ago

Thanks for the contribution! For future reference, please create a branch on your repository when you submit a PR, it makes it easier to make small edits before merging (I'll be following up with some unit tests and etc)