bdunn44 / vaadin-oauthpopup

OAuth Popup Add-on for Vaadin 7.1+
Apache License 2.0
5 stars 10 forks source link

Split oauths #7

Closed nomukaiki closed 7 years ago

nomukaiki commented 7 years ago

I've done this to be able to use the additional parameters when calling the OAuth2 authorisation URL, supported by scribejava but was not allowed in the oauthpopup here: https://github.com/bdunn44/vaadin-oauthpopup/blob/master/oauthpopup/src/main/java/org/vaadin/addon/oauthpopup/OAuthData.java#L292

While doing it I felt it would be worth the effort to decouple the OAuth1 and OAuth2, because they required different logic and allows better customisation to non standard OAuth.