Store false/unchecked value of attribute as well

bdunogier / ezdisqus

Disqus integration for eZ Publish

http://projects.ez.no/ezdisqus

Other

5 stars 9 forks source link

Store false/unchecked value of attribute as well #34

Closed jonmorten closed 10 years ago

jonmorten commented 10 years ago

The value was only stored when the field key was present in $_POST, i.e. when the checkbox was checked. This caused the attribute value to be 'locked' as true if it was ever stored as true/checked.

lolautruche commented 10 years ago

Thanks @jjmmkk ! Could you just please remove the parenthesis?

jonmorten commented 10 years ago

Yes, though I disagree, as I find wrapped ternaries easier to spot.

bdunogier commented 10 years ago

Code style... ;-)

Thank you for the PR @jjmmkk !