search

bdunogier / ezdisqus

Disqus integration for eZ Publish
http://projects.ez.no/ezdisqus
Other
5 stars 9 forks source link

Make disqus_shortname a setting #5

Closed bdunogier closed 12 years ago

bdunogier commented 12 years ago

disqus_shortname is the base disqus variable, the id of a site: http://docs.disqus.com/developers/universal/.

Make it a setting, in disqus.ini:

[Base]
DisqusShortname=default
lolautruche commented 12 years ago

Should only be a default value IMHO. A datatype integration would allow to override this

bdunogier commented 12 years ago

No, not really. It's a sitewide setting... it's like the ananlytics site ID.

I'm making it overridable per template (through include) though.

lolautruche commented 12 years ago

Mmm, what if you have several mini-websites and only one admin then ? We might consider at least to let choose a siteaccess, which should have this setting.

bdunogier commented 12 years ago

Yes, good idea.

Bertrand Dunogier