Open how-eee opened 3 years ago
EXEC_MOTION_CANCEL flag set when changing direction while axis moving
also still cant figure out why А feedrate didnt change actual speed in jog mode maybe im doing something wrong? could you tell me how do you use it?
I have added feedrate change during jog. As it used during PowerFeed config.h
UISupport.cpp if(!UILineBufferIsAvailable()) return; const char source = (gc_state.modal.units)?STR(UI_JOGGING_BASE_STRING_INCH):PSTR(UI_JOGGING_BASE_STRING_METRIC); char cursor = UILineBuffer; char c; while ((c=pgm_read_byte(source++))) cursor++ = c; cursor = sPrintFloat(cursor, 10, jogFeed, 1); //added line set feed cursor++ = activeAxis;
cursor = sPrintFloat(cursor, 10, activeIncrementValue * count, 4);
*cursor = 0;
Also fix a bug of feedrate. It didnt change value if editBuffer<4
void JogUIPage::enterKeyPressed(void) { if(!editingJogFeed) return;
if(editBufferState == 0)
{
jogFeed = 0.0;
}
else
{
while(editBufferState<4) {editBuffer[editBufferState++] = ' ';} //added line
jogFeed = stringToFloat(editBuffer);
}
EXEC_MOTION_CANCEL flag set when changing direction while axis moving
Where did you locate this in the script? Which Line(s) please?
Kind Regards
UIsupport.cpp line 1863 line 1889 and few times later i this file
But I forgot already if the problem still there. it was year ago/ I revised all code and post branch there https://github.com/how-eee/grbl_lathe_UI_threading My lathe still working every day with no issues (minor issues dont count)
UIsupport.cpp
line 1863
line 1889
and few times later i this file
But I forgot already if the problem still there. it was year ago/ I revised all code and post branch there https://github.com/how-eee/grbl_lathe_UI_threading
My lathe still working every day with no issues (minor issues dont count)
Many thanks for your reply...
Kind regards
UIsupport.cpp
line 1863
line 1889
and few times later i this file
But I forgot already if the problem still there. it was year ago/ I revised all code and post branch there https://github.com/how-eee/grbl_lathe_UI_threading
My lathe still working every day with no issues (minor issues dont count)
Many thanks for your reply...
Kind regards
Hello
I've looked at this UISupport.cpp and your UISupport.cpp on your branch and can't see any difference between the two.
Did you rectify this issue?
I've noted that the Jog Wheel has a tendency to change direction when spun quickly which cancels the movement very briefly mid Jog and gives rise to the incomplete travel/movement, hence odd values.
Also, the wheel doesn't respond to the first 'dent' or click when direction is changed, you get like a dead spot. This only happens when direction has been changed though.
Is this an issue in the Protocol script?
Thoughts welcomed...
Kind regards
I assume this is correct behavior. When you jogging your mashine in one direction than rotate encoder another direction it stopped immidiatly with EXEC_MOTION_CANCEL flag. And it doesnt lost its position. If yoг wait until jog motion finished and then rotate wheel to another direction, first click change direction,second click move axis. When you rotate encoder fast it starts to jitter, and you get wrong series of impulses of your encoder. I made 3dprinted own MPG with two latched hall sensors and magnets. It works perfect at any rotation speed. I dont have issues with it anymore.
you can see it here https://youtu.be/8M4gzLkSXls
you can see it here https://youtu.be/8M4gzLkSXls
Hello How-eee
Thanks for the link and reply.
Great job on the DIY Encoder. Works really well it seems.
Following your comments, I've added 10nF caps to the lines on my MPG wheel and it has cleaned up the movement nicely!
Thanks for sharing...
Kind regards
you can see it here https://youtu.be/8M4gzLkSXls
Hello How-eee
Thanks for the link and reply.
Great job on the DIY Encoder. Works really well it seems.
Following your comments, I've added 10nF caps to the lines on my MPG wheel and it has cleaned up the movement nicely!
Thanks for sharing...
Kind regards
How did you connect those caps?
you can see it here https://youtu.be/8M4gzLkSXls
Hello How-eee
Thanks for the link and reply.
Great job on the DIY Encoder. Works really well it seems.
Following your comments, I've added 10nF caps to the lines on my MPG wheel and it has cleaned up the movement nicely!
Thanks for sharing...
Kind regards
How did you connect those caps?
Between both lines and GND
Google 'Rotary Encoder caps'
Kind regards
for example activeIncrementValue = 1.0000 when I turn encoder A or encoder B (if present) slowly - position incremented by 1 as it should. If I turn encoder rapidly back an forth, position incremented accidently by fractional number (for ex. 0.125) If USE_UI_ENCODER_B_ISR enabled or disabled nothing changed. same issue. I tried many different encoders, mpg wheels. Its software issue. I tried to fix it but cant understand UISupport.cpp . My programming abilities too low for it =( please help...