search

bdusell / semiring-einsum

Generic PyTorch implementation of einsum that supports different semirings
https://bdusell.github.io/semiring-einsum/
MIT License
44 stars 8 forks source link

Correct amax(dim=()) behavior #29

Closed davidweichiang closed 2 years ago

davidweichiang commented 2 years ago

torch.amax takes a dim argument which can be a tuple, but if dim=(), then it takes the max over all dimensions, which is (IMO) not correct.