bdutro / deluge-labelplus

24 stars 7 forks source link

3 problems I found #2

Open neo-neo1 opened 4 years ago

neo-neo1 commented 4 years ago

Thanks for forking and maintaining this great plug-in. As I configured my setup with this I found some bugs and crucial suggestions I feel need addressing.

  1. For sub-folders inside main folders, there seems to be incomplete hierarchical inheritance. When the "Downloads" tab are set inside the "Label Options" window they are passed on from the main folder to sub-folder. However, the options set in the "Autolabel" tab seem to be ignored. For example, I'd prefer to set the main folder as "books" and configure the respective autolabel tab options to match it. But, when the "books" folder has a subfolder named "sci-fi" with the respective autolabel tab options set I would prefer for it to inherit the main folder (books/scifi). Instead, the two autolabel options set within a folder and subfolder seem to compete and conflict with each other and either books or books/scifi end up being set rather than to inherit its hierarchical order. I repeat, subfolders do inherit settings from the "Downloads" tab but not the "Autolabel" tab. I suggest a clear hierarchical inheritance option to be user selectable as true or false. This might not be the way LabelPlus was designed, but it would things much more clearer and flexible . At first I had to learn how this Plugin did not work for me to properly know how it did work to set things up.

  2. When the setting "Move Completed" is enabled and configured under the "Downloads" tab in the "Label Options" window it ignores requests when you change the directory inside the "Statusbar" pane under the "Options" tab in the "Move completed" field. I change the directory in "Move completed" field, click "Apply" and it does not move the already downloaded torrent. However, it does work if I right click on the torrent to select "Move Downloaded Folder" then change the directory and click ok. This seems to a conflict of how Deluge works versus LabelPlus.

  3. Being able to input Regex made me switch from my old torrent client to Deluge and use LabelPlus, so thank you immensely. In the Autolabel tab there is a conflicting option. When I select the "match regex" option from the drop down and then insert the respective regex which equates to 'does not match' it simply does not work. I've tried inserting various regex code to accomplish 'does not match' such as ^((?!STRING).)*$ and various other code containing negative lookahead (?!…) and negative lookbehind (?<!…) to no success.