search

be-hacking-hyf / HTML-CSS-GitHub

read this live on github pages
https://be-hacking-hyf.github.io/HTML-CSS-GitHub/
Other
9 stars 16 forks source link

Week3_Mert #45

Open Mert1980 opened 5 years ago

Mert1980 commented 5 years ago

I completed Week3 project (DuckDuckGo) and made it live on my forked repo.

I also completed all of the Module Exercises, however FreeCodeCamp sadly allowed me to save the solutions only in JSON format. I hoped that I would be able to convert them into HTML file. Despite every effort I made, I could not convert JSON files into HTML.

idogrusoz commented 5 years ago

@Mert1980 your page looks neat however there are two issues:

  1. The grey section with the search bar and everything should cover the page before scrolling but in your case, the green section is seen.
  2. Unfortunately, your page is not responsive. I would advise to study on this topic and try to use flex or grid.

I want to add that your commitment and motivation are more valuable than your page's responsiveness. You should keep this mindset and the other issues will be solved in time.

Mert1980 commented 5 years ago

Thank you very much for your review and feedback. I will take your advice in mind.

Kind regards,

Mert

5 Eki 2019 Cmt 16:37 tarihinde IBRAHIM DOGRUSOZ notifications@github.com şunu yazdı:

@Mert1980 https://github.com/Mert1980 your page looks neat however there are two issues:

  1. The grey section with the search bar and everything should cover the page before scrolling but in your case, the green section is seen.
  2. Unfortunately, your page is not responsive. I would advise to study on this topic and try to use flex or grid.

I want to add that your commitment and motivation are more valuable than your page's responsiveness. You should keep this mindset and the other issues will be solved in time.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/be-hacking-hyf/HTML-CSS-GitHub/pull/45?email_source=notifications&email_token=ANEJLEUS7K6ZTDTHPPDWRNLQNCRDXA5CNFSM4I5T6W2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANTUZA#issuecomment-538655332, or mute the thread https://github.com/notifications/unsubscribe-auth/ANEJLEV5QXF6VFYDTNELOMLQNCRDXANCNFSM4I5T6W2A .