PATCH Dynamic apply/unapply TLS monkey patch using preferences.

[GoogleCodeExporter]

I added a preference to apply the patch or reload the original ruby smtp class.

It needs some testing yet.

Follows the patch

Original issue reported on code.google.com by edmundo...@gmail.com on 2 Jul 2008 at 7:34

Attachments:

• tls_patch_preference.patch

[GoogleCodeExporter]

Corrected a typo, a problem reloading the smtp class and tested.

Im not including the test unit as it points to real servers.

Original comment by edmundo...@gmail.com on 3 Jul 2008 at 12:14

Attachments:

• tls_patch_preference_v2.patch

[GoogleCodeExporter]

The patch cleanly applies, but has the following problems...

1 - Missing a db migration to add the preference (attached)
2 - Makes the unit tests error out. Can you check this against trunk?

Original comment by subim...@gmail.com on 11 Aug 2008 at 11:38

• Changed state: Accepted
• Added labels: Priority-High
• Removed labels: Priority-Medium

Attachments:

• 030_gmail_ssl_support.rb

[GoogleCodeExporter]

I was 10 days without internet connection (I was moving from my appartment) I 
will
take a look at this and update the tests. As I said in issue 8 the tests aren't
updated anymore, every time something is added/changed the tests are/need to be
changed too.

Original comment by edmundo...@gmail.com on 12 Aug 2008 at 7:43

[GoogleCodeExporter]

Probably its just missing the preference inside the preferences fixture?

Original comment by edmundo...@gmail.com on 14 Aug 2008 at 7:58

[GoogleCodeExporter]

Pushing on this until issue 119 is fixed.

Original comment by subim...@gmail.com on 18 Aug 2008 at 6:10

[GoogleCodeExporter]

Fixed, r140

Original comment by subim...@gmail.com on 23 Aug 2008 at 12:04

• Changed state: Fixed

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Nevermind :p

Original comment by subim...@gmail.com on 20 Sep 2008 at 12:43

• Changed state: Fixed