be090129 / substruct

Automatically exported from code.google.com/p/substruct
0 stars 0 forks source link

once they enter a shipping address it never goes away #109

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. enter billing and shipping address for an order
2. use back button
3. enter 'only a billing address'

What is the expected output? What do you see instead?
I believe this causes the order to be completed with the shipping address,
still, though this is unexpected by the user.

What version of the product are you using? On what operating system?
1.0a3

Please provide any additional information below.

Note also that the checkbox for "use separate shipping address" does not
currently default to checked, as one would expected it to.

The original problem is probably fixed by changing the very end clause of
update_order_from_post to

...
        else
            # should update it to match the billing???
            @order.billing_address.destroy if @order.billing_address
            @order.update_attributes!(:shipping_address_id => @billing_address.id) #
use the new one
            @shipping_address = OrderAddress.new
        end
end

Though I'm not sure if destroying the old one has any potentially bad side
effects or not.  Like if it has a possibility of being used by other orders
or what not.

Thanks!
-R

Original issue reported on code.google.com by rogerpack2005 on 14 Jul 2008 at 8:56

GoogleCodeExporter commented 8 years ago
Cheers, the majority of ecommerce systems I've used as a customer and worked 
with do
not have the 'use different shipping address' checked by default. Maybe I've
misunderstood what you are saying in this context above though.

Original comment by zhalbre...@gmail.com on 8 Aug 2008 at 4:21

GoogleCodeExporter commented 8 years ago
Use separate shipping address should NOT be checked by default.

The purpose of having *one* set of fields for the customer to fill out is for 
ease of
checkout / speed. Displaying both all the time is a stupid UI move. A large 
majority
of the time the billing and shipping address is the same.

Will take a further look at the other parts of this bug report later.

Original comment by subim...@gmail.com on 16 Aug 2008 at 3:46

GoogleCodeExporter commented 8 years ago

Original comment by subim...@gmail.com on 29 Aug 2008 at 4:32

GoogleCodeExporter commented 8 years ago
I believe I was pointing out that if, previously, they had checked 'use separate
billing' then it erred and came back to the same screen, it would be unchecked. 
You'd expect on err it to stay checked.
I haven't looked into it for quite awhile, so it could use some more 
examination.
Thoughts?

Original comment by rogerpack2005 on 18 Sep 2008 at 3:23