PATCH Wrong value taken into consideration when verifying the minimum cart value to apply promotions or applying percentage promotions.

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Fill a cart, do a checkout and apply a percentage promotion.
2. Go back to the product list, choose the cart and checkout again using
the same percentage promotion.

What is the expected output? What do you see instead?
It should behaves the same. But in the second checkout the values used as
the minimum cart value and the total value to apply the discount are higher. 

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.10

Please provide any additional information below.
The method that applies the promotion is using the total order value. This
value includes shipping and taxes, (and shipping value will only be
available into the order AFTER the first checkout).

I fixed it using only the order items total, I don't agree that discounts
should be applied over shipping nor taxes, same for the minimum cart value.

This issue is related with issue 61. I couldn't reproduce it exactly but it
refers to a percentage promotion problem and another that makes a product
disappear (that I think is subject to another issue).

Original issue reported on code.google.com by edmundo...@gmail.com on 8 May 2008 at 1:16

Attachments:

• order_total_value_for_promotions.patch

[GoogleCodeExporter]

Thanks Edmundo

Original comment by johnd...@gmail.com on 12 Jun 2008 at 7:19

[GoogleCodeExporter]

Great catch Edmundo, I had a customer who brought up the same issue this 
weekend. Thanks!

Fixed with r98

Original comment by subim...@gmail.com on 15 Jun 2008 at 7:18

• Changed state: Fixed