be5invis / Iosevka

Versatile typeface for code, from code.
http://be5invis.github.io/Iosevka
SIL Open Font License 1.1
19.16k stars 569 forks source link

Open octothorpe #621

Closed paolobolzoni closed 4 years ago

paolobolzoni commented 4 years ago

The octothorpe of IBM Plex looks somewhat weird, but it is well readable even when displayed very small. Since Iosevka is used for code and it is very tight I think it would be a valuable addition to have a bit more breeze in the text.

IBM Plex mono octothorpe (IBM Plex mono octothorpe)

be5invis commented 4 years ago

image

paolobolzoni commented 4 years ago

Even after downloading the latest dev code this simple build plan leave the number sign closed and upright... Am I missing something?

I open the resulting regular font with DTL OTMaster and checked the octothorp with Glyph Index (gid) 6.

 $ cat private-build-plans.toml
# parameters.toml

[buildPlans.iosevka-paopao]
family = "Iosevka Paopao test"

design = [ "sp-fixed", "VXBI" ]
hintParams = ["-a", "sss"]

[buildPlans.iosevka-paopao.weights.light]
shape = 300
menu  = 300
css   = 300

[buildPlans.iosevka-paopao.weights.regular]
shape = 500
menu  = 400
css   = 400

[buildPlans.iosevka-paopao.weights.bold]
shape = 700
menu  = 700
css   = 700

[buildPlans.iosevka-paopao.slants]
upright = "normal"
italic = "italic"
be5invis commented 4 years ago

@paolobolzoni What's your command used to build fonts. I used npm run build -- contents::iosevka-paopao and the result match expectation. image

paolobolzoni commented 4 years ago

The command was the same. Then I tried to fully reset the building environment. But after compiling otfccit fails at one test:

[...] [==========] 1990 tests from 183 test suites ran. (5981 ms total)
[  PASSED  ] 1989 tests.
[  FAILED  ] 1 tests, listed below:
[  FAILED  ] premake_http.http_redirect
HTTP response code said error
The requested URL returned error: 404 Not Found

Of course, previously this did not happen. I will try to understand more.

paolobolzoni commented 4 years ago

I know it is not great, but merely skipping the otfcc tests after the compilation and then resetting the whole building environment gave the expected result.