search

be5invis / vscode-custom-css

Custom CSS Plugin for Visual Studio Code. Based on vscode-icon
MIT License
832 stars 58 forks source link

not able to load css from file protocol in insider 1.54 #135

Closed liangch closed 3 years ago

liangch commented 3 years ago

In this insider version, the css file is not able to load by file protocol (file://). Copied the css file to a web server, and use http://, it works.

Version: 1.54.0-insider Electron: 11.2.3 Chrome: 87.0.4280.141 Node.js: 12.18.3 V8: 8.7.220.31-electron.0 OS: Darwin x64 18.7.0

willcode4food commented 3 years ago

I tried serving this up from a Gist and couldn't get it to work.

BinWu-859 commented 3 years ago

I relocated the css file to ~/.vscode/extensions and it works.

denis-gorin commented 3 years ago

I relocated the css file to ~/.vscode/extensions and it works.

+1

be5invis commented 3 years ago

@BinWu-859 If you'd like you could file a PR to update the README for this. Looks like a permission issue.

be5invis commented 3 years ago

Or maybe write some copy logic...

BinWu-859 commented 3 years ago

@BinWu-859 If you'd like you could file a PR to update the README for this. Looks like a permission issue.

It is not related with permission. https://github.com/microsoft/vscode/pull/116522/commits/8e7eca21577ca98c6d8cf33bd594fb17b1fe2b15 made the difference

be5invis commented 3 years ago

It should work now in V5, as the CSS/JS files will be now copied to the extension dir.