beRajeevKumar / Frontend_Mentor

Sharpen Your Frontend Development Expertise with Frontend Mentor Challenges.
https://openfrontendmentor.netlify.app/
MIT License
53 stars 144 forks source link

issue in login.html #381

Open akshitbansal2005 opened 1 month ago

akshitbansal2005 commented 1 month ago
  1. Hardcoded API Key: The Firebase configuration includes a hardcoded API key, which can expose the project to security risks. It's advisable to restrict API key usage in the Firebase console and to avoid exposing sensitive keys in client-side code.

  2. Error Handling: While there is some error handling in the catch block, it only logs the error to the console. It might be better to provide user feedback (like an alert or a message on the page) to inform users of any sign-in issues.

  3. Form Submission Behavior: The Cancel button does not have an associated action. It should either reset the form or redirect the user to a different page.

  4. Image Source: The image source for the sign-in image is /login.webp. If this path is incorrect or the image is not available, it may cause a broken image link.

  5. Accessibility: Ensure that form elements have associated labels for better accessibility. While labels are present, the use of b tags is not semantically necessary; instead, consider using CSS for styling.

  6. Password Field Autocomplete: The autocomplete="new-password" attribute in the password field may be misleading. If the user is signing in, it would be better to use autocomplete="current-password".

  7. Firebase Analytics: The code initializes Firebase Analytics but does not utilize it. Consider whether analytics are needed and remove the initialization if they are not.

  8. Lack of Input Validation: While HTML5 input types (like email and password) provide some validation, additional client-side validation might be necessary for user experience.

github-actions[bot] commented 1 month ago

👋 Thank you @akshitbansal2005 for raising an issue! We appreciate your effort in helping us improve. Our team will review it shortly. Stay tuned!