search

beached / daw_json_link

Fast, convenient JSON serialization and parsing in C++
https://beached.github.io/daw_json_link/
Boost Software License 1.0
474 stars 31 forks source link

Taking a param by value and then creating a copy of it #374

Closed jk-jeon closed 1 year ago

jk-jeon commented 1 year ago

I suspect that this is probably a bug: https://github.com/beached/daw_json_link/blob/release/include/daw/json/impl/daw_json_parse_value.h#L847

The parameter is taken by value but it seems you immediately create a copy of it anyway.

jk-jeon commented 1 year ago

Thanks for the fix!