search

beached / utf_range

Range operations on character arrays
Other
3 stars 3 forks source link

compilation errors caused by `daw::advance` #7

Closed toge closed 8 months ago

toge commented 8 months ago

There is a trivial problem with utf_range and header_libraries >= 2.98.0 without daw_json_link.

include/daw/utf8/unchecked.h: In member function ‘constexpr daw::utf8::unchecked::iterator<octet_iterator> daw::utf8::unchecked::iterator<octet_iterator>::operator++(int)’:
include/daw/utf8/unchecked.h:230:30: error: ‘advance’ is not a member of ‘daw’
  230 |                         daw::advance( it, utf8::internal::sequence_length( it ) );
      |                              ^~~~~~~

It seems to be caused by daw::advance moving from cpp_17.h to cpp_17_iterator.h in header_libraries 2.98.0.

Would you fix them? There seem to be several workarounds:

  1. include cpp_17_iterator.h in unchecked.h
  2. use advance instead of daw::advance
beached commented 8 months ago

Thanks for finding that. Fixed https://github.com/beached/utf_range/releases/tag/v2.2.4

toge commented 8 months ago

@beached Thank you for your quick response!