search

beacon-biosignals / EDF.jl

Read and write EDF files in Julia
MIT License
18 stars 5 forks source link

Remove `nb_header` from the `EDF.Header` specification #22

Closed OTDE closed 4 years ago

OTDE commented 4 years ago

The value generated by nb_header can be calculated pretty easily during the process of writing to EDF. Removing this field allows the caller of EDF.Header to create an instance without needing to specify the number of bytes in the header in advance.

The test for nb_header has additionally been rewritten to test that the value calculated in the revised version of EDF.write is correct.

This resolves issue https://github.com/beacon-biosignals/EDF.jl/issues/21.

codecov-io commented 4 years ago

Codecov Report

Merging #22 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   98.96%   98.96%   +<.01%     
==========================================
  Files           3        3              
  Lines         193      194       +1     
==========================================
+ Hits          191      192       +1     
  Misses          2        2
Impacted Files Coverage Δ
src/EDF.jl 100% <ø> (ø) :arrow_up:
src/read.jl 98.29% <ø> (ø) :arrow_up:
src/write.jl 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2e9dc0...e9363ad. Read the comment docs.