Closed jrevels closed 4 years ago
Some of the tests appear to be erroring. Related to the API changes on the latest commit, maybe?
Looks like the read!
method I was using actually only handles views on Julia >= v1.4; I bumped the minimum Julia version out of laziness. I'm fine with dropping lower Julia versions if other folks are okay with that.
LGTM!!
Ideally, I would've tackled both of these in the review of #26, I just didn't have the foresight at the time. My bad for the API churn!
This makes things slightly more flexible/composable with existing
Base.open
methods rather than implementing our own. It also avoids an extra double-buffering that was happening while reading sample data.master:
this branch:
Extra allocations might be attributable to the
view
usage, but haven't really dug into it. We could probably get the time/memory usage a bit farther down using this approach with a bit of profiling, but this is a strict improvement time/memory-wise so far.