search

beacon-biosignals / Effects.jl

Effects Prediction for Regression Models
MIT License
19 stars 4 forks source link

Add support for function terms #26

Closed palday closed 3 years ago

palday commented 3 years ago

I like the idea of being able to support FunctionTerm, but there is a massive potential footgun here. For example, if we have 1 + sqrt(x) + x , then the typical values of x and sqrt(x) make never co-occur in real data. At the same time, we don't always have access to x and f(x) might not be invertible, so we can't just go back to the untransformed variable to compute the typical values.

Closes #24 Closes #25 (I think)

codecov[bot] commented 3 years ago

Codecov Report

Merging #26 (d1fd758) into main (7cf8287) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head d1fd758 differs from pull request most recent head 8f60870. Consider uploading reports for the commit 8f60870 to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##              main       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           63        75   +12     
=========================================
+ Hits            63        75   +12
Impacted Files Coverage Δ
src/typical.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cf8287...8f60870. Read the comment docs.