search

beacon-biosignals / Effects.jl

Effects Prediction for Regression Models
MIT License
19 stars 4 forks source link

more robust method for extracting response name #34

Closed palday closed 2 years ago

palday commented 2 years ago

It also allows us to deal with e.g. ZScore'd responses.

codecov[bot] commented 2 years ago

Codecov Report

Merging #34 (004ec28) into main (78be505) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 004ec28 differs from pull request most recent head 0e62add. Consider uploading reports for the commit 0e62add to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           75        81    +6     
=========================================
+ Hits            75        81    +6
Impacted Files Coverage Δ
src/regressionmodel.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 78be505...0e62add. Read the comment docs.

palday commented 2 years ago

@kleinschmidt Correct, it would error -- and that's exactly how I discovered this problem.

I'm also torn on the name -- it can be surprising, but it makes it very clear what scale things are on. And if folks really want the original name, they can always specify eff_col.