Closed kolia closed 3 years ago
Cool! Questions:
- Should the README be updated?
Just updated the README. Planning on adding a more fleshed out example (julia_pod) later on.
- should we allow choosing a custom port? Maybe via an environmental variable, since it runs at init time?
do we need access to that task that gets started?
- would we need to restart it for some reason?
Can't think why you'd need to use a different port or to restart, kubectl proxy has been pretty sturdy running for me, but it's easy to add so just did....
Merging #10 (bb2c6da) into main (e0758c0) will increase coverage by
4.37%
. The diff coverage is80.00%
.
@@ Coverage Diff @@
## main #10 +/- ##
========================================
+ Coverage 1.17% 5.55% +4.37%
========================================
Files 2 2
Lines 85 90 +5
========================================
+ Hits 1 5 +4
- Misses 84 85 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/K8sClusterManagers.jl | 71.42% <80.00%> (+21.42%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e0758c0...bb2c6da. Read the comment docs.
kubectl is no longer required to be running in a side-car container
addresses #6
This ends up simplifying a couple of other annoyances:
IMAGE
env variable; since there is only one container in the pod, we can default to using the driver container's image for workers by passingimage=nothing
toaddprocs_pod
.