beacon-biosignals / K8sClusterManagers.jl

A Julia cluster manager for Kubernetes
Other
31 stars 5 forks source link

use kubectl_jll #10

Closed kolia closed 3 years ago

kolia commented 3 years ago

kubectl is no longer required to be running in a side-car container

addresses #6

This ends up simplifying a couple of other annoyances:

ericphanson commented 3 years ago

Cool! Questions:

kolia commented 3 years ago
  • Should the README be updated?

Just updated the README. Planning on adding a more fleshed out example (julia_pod) later on.

  • should we allow choosing a custom port? Maybe via an environmental variable, since it runs at init time?
  • do we need access to that task that gets started?

    • would we need to restart it for some reason?

Can't think why you'd need to use a different port or to restart, kubectl proxy has been pretty sturdy running for me, but it's easy to add so just did....

codecov-io commented 3 years ago

Codecov Report

Merging #10 (bb2c6da) into main (e0758c0) will increase coverage by 4.37%. The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main     #10      +/-   ##
========================================
+ Coverage   1.17%   5.55%   +4.37%     
========================================
  Files          2       2              
  Lines         85      90       +5     
========================================
+ Hits           1       5       +4     
- Misses        84      85       +1     
Impacted Files Coverage Δ
src/K8sClusterManagers.jl 71.42% <80.00%> (+21.42%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0758c0...bb2c6da. Read the comment docs.