search

beacon-biosignals / K8sClusterManagers.jl

A Julia cluster manager for Kubernetes
Other
31 stars 5 forks source link

Use Codecov `after_n_builds` #100

Closed omus closed 1 year ago

omus commented 1 year ago

Trying to reduce noise from Codecov which always reports that coverage has dropped as our unit tests finish far earlier than our cluster tests.

e.g. Screenshot 2023-04-10 at 12 38 02

codecov[bot] commented 1 year ago

Codecov Report

Merging #100 (5c4c01a) into main (22db94b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   66.86%   66.86%           
=======================================
  Files           4        4           
  Lines         172      172           
=======================================
  Hits          115      115           
  Misses         57       57

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

omus commented 1 year ago

Not sure why but this change doesn't seem to be working as expected

Update: No, this change is working as expected but this only affects the comment. The CI status checks still show a coverage reduction until all the tests complete. The only thing this PR did is delay the inline comment until all CI checks have run.