search

beacon-biosignals / K8sClusterManagers.jl

A Julia cluster manager for Kubernetes
Other
31 stars 5 forks source link

Use `gethostname` to determine pod name #101

Closed omus closed 1 year ago

omus commented 1 year ago

The HOSTNAME environmental variable does seem to always be set when running in a K8s pod but other environments should use gethostname to determine the hostname.

omus commented 1 year ago

I'll hold off on bumping the project version here as this currently doesn't impact users of this package

codecov[bot] commented 1 year ago

Codecov Report

Merging #101 (263e04c) into main (22db94b) will increase coverage by 0.76%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   66.86%   67.63%   +0.76%     
==========================================
  Files           4        4              
  Lines         172      173       +1     
==========================================
+ Hits          115      117       +2     
+ Misses         57       56       -1
Impacted Files Coverage Δ
src/native_driver.jl 11.66% <ø> (+3.19%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more