search

beacon-biosignals / K8sClusterManagers.jl

A Julia cluster manager for Kubernetes
Other
31 stars 5 forks source link

Separate keywords `worker_prefix` and `manager_pod_name` #104

Closed omus closed 1 year ago

omus commented 1 year ago

Allows end users to customize the prefix assigned to worker names while still begin able to look up the image of a manager pod. I did like how workers were assigned the name of their manager via labels in the old code but in the new world where we have managers which are external to the cluster this seems more sensible.

codecov[bot] commented 1 year ago

Codecov Report

Merging #104 (2324572) into main (12e9d63) will not change coverage. The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   65.64%   65.64%           
=======================================
  Files           4        4           
  Lines         163      163           
=======================================
  Hits          107      107           
  Misses         56       56
Impacted Files Coverage Δ
src/native_driver.jl 11.66% <50.00%> (ø)
src/pod.jl 97.59% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

omus commented 1 year ago

maybe worth bumping version here as well?

I'm holding off until I get the external manager support in