search

beacon-biosignals / K8sClusterManagers.jl

A Julia cluster manager for Kubernetes
Other
31 stars 5 forks source link

Remove continue-on-error for nightly #14

Closed christopher-dG closed 3 years ago

omus commented 3 years ago

@christopher-dG just curious why this was removed? Seems like it should does work as expected: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error

christopher-dG commented 3 years ago

continue-on-error behaves weirdly, i.e. it's not a real "allow failures". It just reports the job as a pass no matter what happens and any subsequent steps (coverage) run even if the tests failed right away, which can result in some weird stuff like Codecov reporting 1% coverage until the other jobs catch up. But in this case, it was also just because this package does not actually test on nightly.

omus commented 3 years ago

Thanks. Will merge and re-look at this if we ever test against nightly here again.