search

beacon-biosignals / K8sClusterManagers.jl

A Julia cluster manager for Kubernetes
Other
31 stars 5 forks source link

Surface level changes #16

Closed omus closed 3 years ago

omus commented 3 years ago

In preparation for some larger refactoring I reviewed the the package and made some minor changes. I'll hold of on merging these until I get some tests set up.

codecov-io commented 3 years ago

Codecov Report

Merging #16 (6a356a2) into main (7d69788) will increase coverage by 2.13%. The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main     #16      +/-   ##
========================================
+ Coverage   5.55%   7.69%   +2.13%     
========================================
  Files          2       2              
  Lines         90      91       +1     
========================================
+ Hits           5       7       +2     
+ Misses        85      84       -1
Impacted Files Coverage Δ
src/native_driver.jl 0.00% <0.00%> (ø)
src/K8sClusterManagers.jl 77.77% <80.00%> (+6.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d69788...6a356a2. Read the comment docs.

omus commented 3 years ago

I'm going to break this up into discrete PRs

omus commented 3 years ago

The remaining two commits: Restrict ctx field to KuberContext and Refactor do-block unpack I'll either revisit later or include as part of some larger changes.