beacon-biosignals / K8sClusterManagers.jl

A Julia cluster manager for Kubernetes
Other
31 stars 5 forks source link

Drop Kuber.jl dependency #34

Closed omus closed 3 years ago

omus commented 3 years ago

Using Kuber.jl seems like more trouble than it's worth at the moment.

Update: Additional reasons to get rid of Kuber.jl:

codecov-commenter commented 3 years ago

Codecov Report

Merging #34 (8b49288) into main (a605bbe) will increase coverage by 16.79%. The diff coverage is 72.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #34       +/-   ##
===========================================
+ Coverage   34.67%   51.47%   +16.79%     
===========================================
  Files           4        4               
  Lines         124      136       +12     
===========================================
+ Hits           43       70       +27     
+ Misses         81       66       -15     
Impacted Files Coverage Δ
src/K8sClusterManagers.jl 100.00% <ø> (+18.18%) :arrow_up:
src/native_driver.jl 4.41% <7.14%> (-0.07%) :arrow_down:
src/pod.jl 97.91% <97.22%> (+47.91%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a605bbe...8b49288. Read the comment docs.

omus commented 3 years ago

Marking as breaking as this requires users to update their configure functions