search

beacon-biosignals / K8sClusterManagers.jl

A Julia cluster manager for Kubernetes
Other
31 stars 5 forks source link

Avoid waiting for timeout when pod fails #50

Closed omus closed 3 years ago

omus commented 3 years ago

In a scenario where a pod's container fails immediately we could end up waiting the full timeout duration for the pod to reach the "Running" phase. This PR changes the behaviour to only wait while in the "Pending" phase and use a separate error message if the pod skips the "Running" phase entirely.

codecov[bot] commented 3 years ago

Codecov Report

Merging #50 (bbcb5c6) into main (6cf9e26) will increase coverage by 0.67%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   69.69%   70.37%   +0.67%     
==========================================
  Files           4        4              
  Lines         132      135       +3     
==========================================
+ Hits           92       95       +3     
  Misses         40       40
Impacted Files Coverage Δ
src/pod.jl 95.94% <100.00%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6cf9e26...bbcb5c6. Read the comment docs.