search

beacon-biosignals / K8sClusterManagers.jl

A Julia cluster manager for Kubernetes
Other
31 stars 5 forks source link

Redirect worker output via `kubectl logs -f` #57

Closed omus closed 3 years ago

omus commented 3 years ago

Addresses: https://github.com/beacon-biosignals/K8sClusterManagers.jl/issues/56

omus commented 3 years ago

I'll forge ahead with this PR as #58 isn't ready and I want to make a release today

codecov[bot] commented 3 years ago

Codecov Report

Merging #57 (45fe82e) into main (6df57b4) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   67.63%   67.63%           
=======================================
  Files           4        4           
  Lines         173      173           
=======================================
  Hits          117      117           
  Misses         56       56
Impacted Files Coverage Δ
src/native_driver.jl 7.01% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6df57b4...45fe82e. Read the comment docs.

omus commented 3 years ago

I think the current implementation of this is rather good now. My only real complaint is that we can no longer use --bind-to to specify the port... And I think I figured out how to get that to work

omus commented 3 years ago

I think the current implementation of this is rather good now. My only real complaint is that we can no longer use --bind-to to specify the port... And I think I figured out how to get that to work

Nope, by looking at the Distributed code it did appear that setting host would have worked but I missed that bind_addr is used initially