beacon-biosignals / K8sClusterManagers.jl

A Julia cluster manager for Kubernetes
Other
31 stars 5 forks source link

Stable docs still show v0.0.2 #74

Closed omus closed 3 years ago

christopher-dG commented 3 years ago

I think this:

https://github.com/beacon-biosignals/K8sClusterManagers.jl/blob/d17520380d6efa00e1d5fae273df57f9e748b17e/.github/workflows/CI.yml#L3-L5

Needs to have tags: '*' added to it. Although @kleinschmidt had some not-fun adventures with trying to get this to work.

kleinschmidt commented 3 years ago

This was what did it for me: https://github.com/beacon-biosignals/OndaEDF.jl/pull/19/files

For whatever reason with the old config tag pushes weren't even triggering builds; after this PR they did (both manual tags and tagbot). AFAICT the only thing that would have changed there was to replace tags: "*" with tags: '*'

omus commented 3 years ago

75 did fix the issue.