search

beacon-biosignals / K8sClusterManagers.jl

A Julia cluster manager for Kubernetes
Other
31 stars 5 forks source link

Use thread-safe executable product call #86

Closed ericphanson closed 3 years ago

ericphanson commented 3 years ago

I ran into essentially the same issue as https://discourse.julialang.org/t/ioerror-could-not-spawn-argument-list-too-long/43728/12

when launching 20 workers.

omus commented 3 years ago

Just a reminder that Julia 1.6 is required to use the new thread-safe executable product: https://github.com/JuliaPackaging/JLLWrappers.jl/blob/dd045e0576ddf834754100af4cc4829b236ae801/src/products/executable_generators.jl#L47-L70

omus commented 3 years ago

Note Julia "1" and "1.6" are currently equivalent but "1.7" will be out soonish so I'd rather do redundant testing for now

codecov[bot] commented 3 years ago

Codecov Report

Merging #86 (8ee6bfa) into main (b45dfac) will not change coverage. The diff coverage is 90.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           4        4           
  Lines         177      168    -9     
=======================================
- Hits          118      112    -6     
+ Misses         59       56    -3
Impacted Files Coverage Δ
src/native_driver.jl 8.62% <0.00%> (+0.42%) :arrow_up:
src/namespace.jl 100.00% <100.00%> (ø)
src/pod.jl 97.80% <100.00%> (+0.92%) :arrow_up:
src/K8sClusterManagers.jl 66.66% <0.00%> (-33.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b45dfac...8ee6bfa. Read the comment docs.