beacon-biosignals / Legolas.jl

Tables.jl-friendly mechanisms for constructing, reading, writing, and validating Arrow tables against extensible, versioned, user-specified schemas.
Other
24 stars 2 forks source link

Compat fix for ConstructionBase 1.5.7 #123

Closed omus closed 1 month ago

omus commented 1 month ago

Fixing the following issue on Julia 1.6 with ConstructionBase 1.5.7:

Macro invocation doesn't require Legolas module name in caller's scope: Error During Test at /home/runner/work/Legolas.jl/Legolas.jl/test/runtests.jl:208
  Got exception outside of a @test
  UndefVarError: check_patch_properties_exist not defined
  Stacktrace:
    [1] setproperties(r::Main.Namespace91.A91V1, patch::NamedTuple{(:a,), Tuple{Int64}})
      @ Legolas.LegolasConstructionBaseExt ~/work/Legolas.jl/Legolas.jl/ext/LegolasConstructionBaseExt.jl:20
    [2] set(obj::Main.Namespace91.A91V1, l::PropertyLens{:a}, val::Int64)
      @ Accessors ~/.julia/packages/Accessors/hSII3/src/optics.jl:401
    [3] macro expansion
      @ ~/work/Legolas.jl/Legolas.jl/test/runtests.jl:218 [inlined]
    [4] macro expansion
      @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
    [5] top-level scope
      @ ~/work/Legolas.jl/Legolas.jl/test/runtests.jl:211
    [6] include(fname::String)
      @ Base.MainInclude ./client.jl:444
    [7] top-level scope
      @ none:6
    [8] eval
      @ ./boot.jl:360 [inlined]
    [9] exec_options(opts::Base.JLOptions)
      @ Base ./client.jl:261
   [10] _start()
      @ Base ./client.jl:485

https://github.com/beacon-biosignals/Legolas.jl/actions/runs/10600836570/job/29379251401?pr=122#step:6:214

omus commented 1 month ago

@ararslan can you review as you originally added this extension in #112?