Allow missing weights in row construction.

[hannahilea]

Test needed!

[codecov[bot]]

Codecov Report

Merging #14 (5fcd62a) into main (80569ab) will increase coverage by 0.24%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   93.87%   94.11%   +0.24%     
==========================================
  Files           2        2              
  Lines          49       51       +2     
==========================================
+ Hits           46       48       +2     
  Misses          3        3              

Impacted Files	Coverage Δ
src/LegolasFlux.jl	91.89% <100.00%> (+0.46%)	:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[femtomc]

@hannahilea / @ericphanson what sort of test would work here? Would construction with missing weights be appropriate?

[hannahilea]

yep!

[ericphanson]

I think we also don't want to check in test/my_model.model.arrow

[femtomc]

oops, can I add that to .gitignore (?)

[ericphanson]

sure!

[femtomc]

Interesting -- I think it depends on what we want semantically. It seems like adding missing as an element fixes the issue. I'm not exactly sure if that's good or bad.

[ericphanson]

I think #15 might be a simpler approach

[femtomc]

Closing in lieu of #15.