search

beacon-biosignals / LegolasFlux.jl

Save Flux model weights in Legolas-powered Arrow tables
MIT License
6 stars 1 forks source link

Add serialization reference test & bump Legolas compat #22

Closed ericphanson closed 1 year ago

ericphanson commented 1 year ago

This should be merged before #21!

codecov[bot] commented 1 year ago

Codecov Report

Merging #22 (7ea0c42) into main (c76ddb0) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files           2        2           
  Lines          49       49           
=======================================
  Hits           46       46           
  Misses          3        3
Impacted Files Coverage Δ
src/LegolasFlux.jl 91.17% <0.00%> (-0.26%) :arrow_down:
src/functors.jl 100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ericphanson commented 1 year ago

Maybe we can drop pre-Legolas v0.4 in this PR; I think that's still non-breaking, nothing from our API changed. (The problem is nested serialization doesn't work right on pre-v0.4, as I'm sure you remember Dave 😄).