search

beacon-biosignals / LighthouseFlux.jl

An adapter package that implements Lighthouse's framework interface for Flux
MIT License
1 stars 1 forks source link

Bump Flux version to v0.11, Zygote to 0.5 #13

Closed hannahilea closed 4 years ago

jrevels commented 4 years ago

Hmmm, looks like there's a dependency mismatch somewhere or just a bug/missing deprecation in the Flux stack:

ERROR: LoadError: LoadError: UndefVarError: functorm not defined
Stacktrace:
 [1] @treelike(::LineNumberNode, ::Module, ::Vararg{Any,N} where N) at /home/travis/.julia/packages/Flux/IjMZL/src/functor.jl:58
 [2] include at ./boot.jl:328 [inlined]
 [3] include_relative(::Module, ::String) at ./loading.jl:1105
 [4] include(::Module, ::String) at ./Base.jl:31
 [5] include(::String) at ./client.jl:424
 [6] top-level scope at none:6
in expression starting at /home/travis/build/beacon-biosignals/LighthouseFlux.jl/test/runtests.jl:10
in expression starting at /home/travis/build/beacon-biosignals/LighthouseFlux.jl/test/runtests.jl:10
ERROR: Package LighthouseFlux errored during testing
hannahilea commented 4 years ago

(should have looked at CI before approving)

No worries, I wouldn't merge it without that passing anyway. On it!

hannahilea commented 4 years ago

They never did a real deprecation of @treelike, they just had in a comment somewhere that it was "deprecated," as far as I've seen. Good to know that it was similarly removed without proper warning...

Yeah, I figured it out because the fallback function for calling @treelike failed due to not being implemented...