search

beacon-biosignals / LighthouseFlux.jl

An adapter package that implements Lighthouse's framework interface for Flux
MIT License
1 stars 1 forks source link

Test is sensitive to RNG #33

Closed ericphanson closed 2 years ago

ericphanson commented 2 years ago

https://github.com/beacon-biosignals/LighthouseFlux.jl/blob/e58e900768d244e39cc43e5309891585956cd81d/test/runtests.jl#L50-L52

is failing. I think we should try to scrap it and come up with a more robust test, since I remember this being an issue in the past too.

xref https://github.com/beacon-biosignals/LighthouseFlux.jl/pull/32

hannahilea commented 2 years ago

I think we should try to scrap it and come up with a more robust test, since I remember this being an issue in the past too.

Agreed! Although I am confused that this is a problem at all, seeing as we're using StableRNGs here everywhere I'd expect it to matter (without having poked around any deeper).

hannahilea commented 2 years ago

FINALLY. 🏆