search

beacon-biosignals / Onda.jl

A Julia package for high-throughput manipulation of structured signal data across arbitrary domain-specific encodings, file formats and storage layers
Other
67 stars 5 forks source link

Missing method for `Base.hash` #150

Closed ericphanson closed 7 months ago

ericphanson commented 7 months ago

Onda defines isequal (and ==) but not hash, allowing two samples to be isequal but have different hashes (which breaks the docstring of isequal along with dicts etc):

https://github.com/beacon-biosignals/Onda.jl/blob/9a45862978db185b0194f0a32371e4793e327e58/src/samples.jl#L61-L75

We should define hash in the same way as isequal to make them consistent.